Add missing Movable protocol to ElectronAnalyserDetector - #2190
Merged
oliwenmandiamond merged 3 commits intoSep 3, 2026
Conversation
oliwenmandiamond
requested review from
DG-At-Diamond,
Relm-Arrowny and
Villtord
August 26, 2026 09:33
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2190 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 367 367
Lines 14379 14380 +1
=======================================
+ Hits 14284 14285 +1
Misses 95 95 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Villtord
approved these changes
Sep 3, 2026
oliwenmandiamond
enabled auto-merge (squash)
September 3, 2026 16:19
oliwenmandiamond
deleted the
Add_movable_protocol_for_electron_analyser
branch
September 3, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}